Move the Log4j ENV variable to the java-base image#727
Merged
Conversation
ENV variables are inherited by images if they come from a parent image. This ENV variable disables the Log4j feature that caused CVE-2021-4428 (Log4Shell). Even though this probably has been disabled everywhere already it doesn't hurt to set this variable
maltesander
previously approved these changes
Jun 20, 2024
Member
maltesander
left a comment
maltesander
left a comment
There was a problem hiding this comment.
Thanks, LGTM. Could use a changelog entry though?
Member
Author
|
Will do |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ENV variables are inherited by images if they come from a parent image. This ENV variable disables the Log4j feature that caused CVE-2021-4428 (Log4Shell). Even though this probably has been disabled everywhere already it doesn't hurt to set this variable